Change JavaPlugin_additionalInfo_affordance text #2289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
This commit chnages the text of JavaPlugin_additionalInfo_affordance to also mention hover as the PopupCloser in eclipse.platform.ui also reacts to hovering now. contributes to eclipse-jdt#62 and eclipse-jdt#128
amartya4256
force-pushed
the
amartya4256/popup_closer_message_change
branch
from
1990b53 to
2fd5f20
Compare
Contributor
|
|
2 tasks
Contributor
|
eclipse-platform/eclipse.platform.ui#2977 has been merged so this one is ready to be reviewed and merged. I don't have committer rights so would someone be so kind? :-) |
Contributor
|
Thank you, @iloveeclipse ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the text of JavaPlugin_additionalInfo_affordance to also mention hover as the PopupCloser in eclipse.platform.ui also reacts to hovering now.
contributes to #62 and #128
This PR is needed for eclipse-platform/eclipse.platform.ui#2977 and depends on it.
Before:
After:
What it does
How to test
Author checklist